Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove negative margins leftovers #30596

Merged
merged 4 commits into from
Apr 18, 2020

Conversation

MartijnCuppens
Copy link
Member

... and fix the header height.

@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Apr 15, 2020
@XhmikosR
Copy link
Member

It might still be worth reverting #30585, though. We should discuss this further.

v5 automation moved this from Inbox to Approved Apr 15, 2020
@MartijnCuppens
Copy link
Member Author

It might still be worth reverting #30585, though. We should discuss this further.

It would be easy to restore them if needed. I don't expect these were widely used since we only used them in responsive gutter example.

@XhmikosR
Copy link
Member

@mdo WDYT?

@XhmikosR XhmikosR requested a review from mdo April 17, 2020 15:23
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say :shipit:!

@XhmikosR XhmikosR merged commit b79e55f into master Apr 18, 2020
v5 automation moved this from Approved to Shipped Apr 18, 2020
@XhmikosR XhmikosR deleted the master-mc-remove-negative-margins-leftovers branch April 18, 2020 06:11
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants