Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update karma conf and karma-browserstack-launcher #30720

Merged
merged 3 commits into from
May 4, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented May 4, 2020

  • use the recommended karma-browserstack-launcher settings
  • update karma-browserstack-launcher to the latest version

https://github.com/browserstack/karma-browserstack-example/blob/540e6ffd457ec6f0c59627b1d310a0c3109c27b0/karma.conf.js#L85-L89

@XhmikosR XhmikosR requested a review from a team as a code owner May 4, 2020 13:40
@XhmikosR XhmikosR added this to Inbox in v5 via automation May 4, 2020
@XhmikosR XhmikosR added this to Inbox in v4.5.0 via automation May 4, 2020
@XhmikosR XhmikosR changed the title Update karma.conf.js Update karma conf and karma-browserstack-launcher May 4, 2020
@XhmikosR XhmikosR force-pushed the master-xmr-karma-browserstack branch from 33eb9bb to d8813a7 Compare May 4, 2020 14:20
Use the recommended karma-browserstack-launcher settings
@XhmikosR XhmikosR force-pushed the master-xmr-karma-browserstack branch from d8813a7 to 24968d7 Compare May 4, 2020 14:25
@XhmikosR
Copy link
Member Author

XhmikosR commented May 4, 2020

If this breaks BrowserStack again, we can revert it later. I really hope this fixes the BrowserStack issues once and for all, though.

v5 automation moved this from Inbox to Approved May 4, 2020
@XhmikosR XhmikosR merged commit 56190d0 into master May 4, 2020
v5 automation moved this from Approved to Shipped May 4, 2020
@XhmikosR XhmikosR deleted the master-xmr-karma-browserstack branch May 4, 2020 17:01
@XhmikosR XhmikosR moved this from Inbox to Cherry-picked in v4.5.0 May 4, 2020
@XhmikosR XhmikosR removed this from Shipped in v5 May 5, 2020
@XhmikosR XhmikosR removed this from Cherry-picked in v4.5.0 May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants