Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested tabs (using .tabs within .tab-content) - bootstrap-tabs.js #310

Closed
coonce opened this issue Sep 26, 2011 · 5 comments
Closed

nested tabs (using .tabs within .tab-content) - bootstrap-tabs.js #310

coonce opened this issue Sep 26, 2011 · 5 comments
Labels

Comments

@coonce
Copy link

coonce commented Sep 26, 2011

When switching tabs on the outer container, the inner tabs get their 'active' class removed also.

I changed line 24 from:
container.find('.active').removeClass('active')
to
container.children('.active').removeClass('active')

Seems to work for me. Is there any reason to remove the 'active' class from all descendants?

@fat
Copy link
Member

fat commented Sep 26, 2011

nope, just didn't think would do that. Good call.

@jewilmeer
Copy link

Tnx @jigawatt121, great this helped me out

@mdo
Copy link
Member

mdo commented Sep 29, 2011

@fat Are you going to add this to 1.4-wip? That'd be awesome.

@fat
Copy link
Member

fat commented Sep 29, 2011

yep i will

@fat
Copy link
Member

fat commented Sep 30, 2011

this has just been resolved in master, thanks!

@fat fat closed this as completed Sep 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants