Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize caret #31101

Closed
wants to merge 1 commit into from
Closed

Modernize caret #31101

wants to merge 1 commit into from

Conversation

inwardmovement
Copy link
Contributor

@mdo
Copy link
Member

mdo commented Jun 18, 2020

Quick feedback:

  • Don't commit dist files
  • Don't change stylelint rules

Can you undo that and re-push?

@mdo
Copy link
Member

mdo commented Jun 18, 2020

Screen Shot 2020-06-18 at 10 43 08 AM

Also, this new caret is uneven—the right side sits higher than the left.

@inwardmovement
Copy link
Contributor Author

inwardmovement commented Jun 18, 2020

I don't know how I can make this PR while complying with the stylelint rules, and cannot spend more time on this for now as I don't know if we want this feature (otherwise I may dive deeper in making a "real" PR). It's just to give an idea for #31069. Maybe I should've just provided a preview, not made a PR...

@inwardmovement
Copy link
Contributor Author

inwardmovement commented Jun 18, 2020

That's weird, it's even from here:
image
(Windows 10, Firefox Dev Edition)

@mdo
Copy link
Member

mdo commented Jun 18, 2020

Let's have you hold on it then for now and we can try to figure it out :). Thanks for submitting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants