Docs: (subjectively) nicer looking accordion example #31137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the use of `.btn-link` currently just looks a bit odd, subjectively (as in v5 we now force the underline to always be there, while in v4 at least it was only on hover/focus). `.btn-light` seems more fitting
|
Current look in v5: After change: |
|
I suggest more additional classes :)
Before: After: |
|
the example with more classes does look good. wonder though if it will obscure the point of the example? |
|
There's a PR to make a dedicated accordion component at #30042. Maybe we explore that? |
|
Added extra classes as suggested by @ysds |
|
Also squeaked in a tiny clarification in the accessibility note there about what bootstrap doesn't support (the optional keyboard interactions) |
|
any more thoughts on this? |
mdo
approved these changes
Sep 10, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* Docs: (subjectively) nicer looking accordion example the use of `.btn-link` currently just looks a bit odd, subjectively (as in v5 we now force the underline to always be there, while in v4 at least it was only on hover/focus). `.btn-light` seems more fitting * Add extra classes for nicer overall look as suggested by @ysds * Tweak accessibility note for accordions and optional keyboard interactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the use of
.btn-linkcurrently just looks a bit odd, subjectively (as in v5 we now force the underline to always be there, while in v4 at least it was only on hover/focus)..btn-lightseems more fitting