Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single line example for inline forms #31240

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Single line example for inline forms #31240

merged 2 commits into from
Jul 11, 2020

Conversation

rohit2sharma95
Copy link
Collaborator

Closes #31230

@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha2 via automation Jul 5, 2020
v5.0.0-alpha2 automation moved this from Inbox to Approved Jul 6, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Jul 6, 2020

Maybe we should switch to row-cols-lg-auto? BTW it seems the other examples above suffer too in some breakpoints between md and lg

@rohit2sharma95
Copy link
Collaborator Author

Should I update PR then? @XhmikosR

@XhmikosR
Copy link
Member

XhmikosR commented Jul 7, 2020

Not sure yet, maybe better wait until someone else chimes in too :)

@mdo mdo merged commit 6acdfdb into twbs:main Jul 11, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Jul 11, 2020
@rohit2sharma95 rohit2sharma95 deleted the inline-forms-example branch July 17, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.0.0-alpha2
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: inline forms example wraps to two lines in new v5 layout
4 participants
@rohit2sharma95 @XhmikosR @mdo @MartijnCuppens