-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md: show brotli size too #31259
Conversation
Sounds good
BS4 doesn't support Brotli, so backporting doesn't feel right. |
That's unrelated 😛 |
Another solution would be to maybe add a separate table with the dist files and their sizes? |
I mean IE, woops. |
Yeah, but we don't care about that here. It's a useful metric and servers do fall back to gzip. |
d0de6af
to
7c07183
Compare
So, to summarize, we can check for both gzip and brotli in bundlewatch and show both in README.md. @mdo WDYT? |
Sounds reasonable to me! |
7c07183
to
9393382
Compare
How about just showing both in README.md for starters? What we use in bundlewatch shouldn't matter a lot. |
9393382
to
e3c9105
Compare
This was something @MartijnCuppens suggested some time ago on Slack.
My only concern is that gzip is the defacto compression used. We could probably keep both sizes in README.md as a middle solution?
Also, not sure if we should backport this or not.
/CC @mdo @ffoodd @MartijnCuppens @Johann-S