Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: show brotli size too #31259

Merged
merged 2 commits into from
Sep 24, 2020
Merged

README.md: show brotli size too #31259

merged 2 commits into from
Sep 24, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jul 8, 2020

This was something @MartijnCuppens suggested some time ago on Slack.

My only concern is that gzip is the defacto compression used. We could probably keep both sizes in README.md as a middle solution?

Also, not sure if we should backport this or not.

/CC @mdo @ffoodd @MartijnCuppens @Johann-S

@MartijnCuppens
Copy link
Member

My only concern is that gzip is the defacto compression used. We could probably keep both sizes in README.md as a middle solution?

Sounds good

Also, not sure if we should backport this or not.

BS4 doesn't support Brotli, so backporting doesn't feel right.

@XhmikosR
Copy link
Member Author

XhmikosR commented Jul 8, 2020

BS4 doesn't support Brotli, so backporting doesn't feel right.

That's unrelated 😛

@XhmikosR
Copy link
Member Author

XhmikosR commented Jul 8, 2020

Another solution would be to maybe add a separate table with the dist files and their sizes?

@MartijnCuppens
Copy link
Member

BS4 doesn't support Brotli, so backporting doesn't feel right.
That's unrelated 😛

I mean IE, woops.

@XhmikosR
Copy link
Member Author

XhmikosR commented Jul 8, 2020

BS4 doesn't support Brotli, so backporting doesn't feel right.
That's unrelated 😛

I mean IE, woops.

Yeah, but we don't care about that here. It's a useful metric and servers do fall back to gzip.

@XhmikosR XhmikosR marked this pull request as ready for review September 10, 2020 10:32
@XhmikosR XhmikosR requested a review from mdo September 10, 2020 10:32
@XhmikosR
Copy link
Member Author

So, to summarize, we can check for both gzip and brotli in bundlewatch and show both in README.md.

@mdo WDYT?

@mdo
Copy link
Member

mdo commented Sep 17, 2020

Sounds reasonable to me!

@XhmikosR
Copy link
Member Author

How about just showing both in README.md for starters? What we use in bundlewatch shouldn't matter a lot.

@XhmikosR XhmikosR changed the title Switch to Brotli README.md: show brotli size too Sep 21, 2020
@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha2 via automation Sep 24, 2020
v5.0.0-alpha2 automation moved this from Inbox to Approved Sep 24, 2020
@XhmikosR XhmikosR merged commit adc70c7 into main Sep 24, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Sep 24, 2020
@XhmikosR XhmikosR deleted the master-xmr-brotli branch September 24, 2020 19:11
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-alpha2
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants