Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Safari long-press / callout on btn-outline styled links causes temporarily unreadable white-on-white styles #31315

Closed
mohsen1 opened this issue Jul 17, 2020 · 9 comments

Comments

@mohsen1
Copy link

mohsen1 commented Jul 17, 2020

Notice the button label after pop over is closed

https://gfycat.com/presentgoldendore

@patrickhlauke patrickhlauke changed the title iOS popover and hover on v5 button looks strange iOS Safari link causes temporarily unreadable/ugly button links Jul 17, 2020
@patrickhlauke
Copy link
Member

suspect this is something to do with -webkit-tap-highlight-color and similar proprietary/non-standard CSS rules for Safari/WebKit

@mdo
Copy link
Member

mdo commented Jan 14, 2021

Tried removing the tap highlight in #32792 and I still see the same problem on those homepage buttons.

@patrickhlauke
Copy link
Member

Tried a variety of things (from setting explicit backgrounds to the outline button styles, to removing the tap highlighting suppression, even down to suppressing the -webkit-touch-callout altogether, which completely breaks users' ability to open a link in a new tab etc) ... but nothing really works. at this stage it looks like a weird quirk (triggered by some unknown combination of styles we use) in Safari, which seems to use some weird heuristic to determine which foreground/background colour it should use for its long-press callout (and then leaves some focus/hover styles hanging until you tap somewhere else if you bail out). Wonder if @graouts has the time/inclination to work out what's going on here...

@patrickhlauke patrickhlauke changed the title iOS Safari link causes temporarily unreadable/ugly button links iOS Safari long-press / callout on btn-outline styled links causes temporarily unreadable white-on-white styles Jan 16, 2021
@patrickhlauke
Copy link
Member

youtube video of the issue, which also shows that the :focus/:hover style "sticks" if the user bails out of the callout, until the user taps anywhere else on the page. https://www.youtube.com/watch?v=_xCNSgieCuY

@smfr
Copy link

smfr commented Jan 21, 2021

Would be good to file a bug at bugs.webkit.org for this.

@patrickhlauke
Copy link
Member

Would be good to file a bug at bugs.webkit.org for this.

@smfr bug filed https://bugs.webkit.org/show_bug.cgi?id=220899 - also made a reduced test case https://codepen.io/patrickhlauke/pen/ExgBxwv

@XhmikosR
Copy link
Member

XhmikosR commented Feb 9, 2021

@mdo @patrickhlauke do we close this as a browser bug and subsequently #32792?

@patrickhlauke
Copy link
Member

we don't list/maintain known browser bugs anymore, right?

but yeah i'd say close it and #32792

@XhmikosR
Copy link
Member

Not anymore since basically v3. v4 does have the Wall of Browser Bugs page but it's basically unmaintained and removed in v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants