Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off scroll anchoring for accordions #31346

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

patrickhlauke
Copy link
Member

New default behavior for scroll anchoring (rolled out in Chrome 84?) leads to unsightly/odd accordion interactions - see #31341
This rule suppresses this new behavior and reverts back to the old way.

See https://drafts.csswg.org/css-scroll-anchoring/

Closes #31341

@patrickhlauke patrickhlauke requested a review from a team July 21, 2020 15:42
@patrickhlauke patrickhlauke added this to Inbox in v5.0.0-alpha2 via automation Jul 21, 2020
New default behavior for scroll anchoring (rolled out in Chrome 84?) leads to unsightly/odd accordion interactions - see #31341
This rule suppresses this new behavior and reverts back to the old way.

See https://drafts.csswg.org/css-scroll-anchoring/
@patrickhlauke patrickhlauke force-pushed the v5-accordion-suppress-scroll-anchoring branch from 9653e98 to e7f0384 Compare July 21, 2020 15:47
@patrickhlauke
Copy link
Member Author

v5.0.0-alpha2 automation moved this from Inbox to Approved Jul 21, 2020
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickhlauke patrickhlauke merged commit c7bc7a3 into main Jul 21, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Jul 21, 2020
@patrickhlauke patrickhlauke deleted the v5-accordion-suppress-scroll-anchoring branch July 21, 2020 17:17
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
New default behavior for scroll anchoring (rolled out in Chrome 84?) leads to unsightly/odd accordion interactions - see twbs#31341
This rule suppresses this new behavior and reverts back to the old way.

See https://drafts.csswg.org/css-scroll-anchoring/
@Hiws Hiws mentioned this pull request Oct 30, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-alpha2
  
Shipped
Development

Successfully merging this pull request may close these issues.

Accordion scroll behavior in Chrome
2 participants