Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust sizing of checks and radios #31383

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Adjust sizing of checks and radios #31383

merged 2 commits into from
Jul 31, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Jul 31, 2020

Moves from 1.25em to 1em to better support custom font-size-base values. Most common would probably be .875rem (14px) and current sizing garbles that into 1.09-ish, thus causing the rendering issues in #31269.

https://deploy-preview-31383--twbs-bootstrap.netlify.app/docs/5.0/forms/checks-radios/

Moves from 1.25em to 1em to better support custom font-size-base values. Most common would probably be .875rem (14px) and current sizing garbles that into 1.09-ish, thus causing the rendering issues in #31269.
@mdo mdo requested a review from a team as a code owner July 31, 2020 05:07
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like

@MartijnCuppens MartijnCuppens added this to Inbox in v5.0.0-alpha2 via automation Jul 31, 2020
@XhmikosR XhmikosR merged commit 16adcf2 into main Jul 31, 2020
v5.0.0-alpha2 automation moved this from Inbox to Shipped Jul 31, 2020
@XhmikosR XhmikosR deleted the checks-radios-sizing branch July 31, 2020 13:49
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Moves from 1.25em to 1em to better support custom font-size-base values. Most common would probably be .875rem (14px) and current sizing garbles that into 1.09-ish, thus causing the rendering issues in twbs#31269.

Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.0.0-alpha2
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants