Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update current_ruby_version to 5.0.0.alpha1 #31455

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Update current_ruby_version to 5.0.0.alpha1 #31455

merged 2 commits into from
Aug 11, 2020

Conversation

glebm
Copy link
Member

@glebm glebm commented Aug 9, 2020

No description provided.

@glebm glebm requested a review from XhmikosR August 9, 2020 09:50
@XhmikosR
Copy link
Member

XhmikosR commented Aug 9, 2020

@glebm that would be an issue because we use the same format everywhere else. Can't you publish it with a hyphen? Otherwise I'll need to remember to bump it manually which increases greatly the chances of making a mistake.

@glebm
Copy link
Member Author

glebm commented Aug 9, 2020

The hyphen is not a valid character for a rubygem version IIRC

@XhmikosR
Copy link
Member

XhmikosR commented Aug 9, 2020

Well, that's too bad. We always used a hyphen https://www.npmjs.com/package/bootstrap?activeTab=versions

I'll think about it, but worst case I guess we bump it separately in case I miss it.

@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha2 via automation Aug 9, 2020
v5.0.0-alpha2 automation moved this from Inbox to Approved Aug 11, 2020
@XhmikosR XhmikosR merged commit 180a0dc into main Aug 11, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Aug 11, 2020
@XhmikosR XhmikosR deleted the glebm-patch-1 branch August 11, 2020 13:35
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-alpha2
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants