Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use next breakpoint when targetting xs only #31500

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Aug 18, 2020

Fixes #31199

I made a Sassmeister to try this. Simply change $upper to $name on L327 to reproduce the issue.

@ffoodd ffoodd requested a review from a team as a code owner August 18, 2020 14:38
@MartijnCuppens
Copy link
Member

Maybe $next is a better name than $upper?

@mdo mdo added this to Inbox in v5.0.0-alpha2 via automation Aug 22, 2020
@mdo mdo merged commit 7058f89 into main Aug 22, 2020
v5.0.0-alpha2 automation moved this from Inbox to Shipped Aug 22, 2020
@mdo mdo deleted the fod-main-media-only-xs branch August 22, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.0.0-alpha2
  
Shipped
Development

Successfully merging this pull request may close these issues.

media-breakpoint-only(xs) not working
3 participants