Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download link in README #31588

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Download link in README #31588

merged 4 commits into from
Sep 10, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Sep 3, 2020

Fixes #31585

@mdo mdo added this to Inbox in v5.0.0-alpha2 via automation Sep 4, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Sep 4, 2020

Note that this was done intentionally and there might be more places.

@ffoodd
Copy link
Member Author

ffoodd commented Sep 7, 2020

@XhmikosR I didn't find any other occurrences, since even the _config.yml targets the alpha release.
And I may be wrong but README.md is handled by build/change-version.js, so there's no real point to use an invalid target here, is it?

@XhmikosR
Copy link
Member

XhmikosR commented Sep 8, 2020

I'm not sure why I left some links TBH, but I'd like to have a closer look and wrap this properly :)

@XhmikosR
Copy link
Member

The only other instance is composer require twbs/bootstrap:5.0.0. I'll try it later to see if it works and update the PR if needed.

v5.0.0-alpha2 automation moved this from Inbox to Approved Sep 10, 2020
@XhmikosR XhmikosR merged commit 08516e4 into main Sep 10, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Sep 10, 2020
@XhmikosR XhmikosR deleted the main-fod-readme-download-link branch September 10, 2020 10:26
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@ffoodd @XhmikosR @olsza
Download link in README (twbs#31588)
4a67522 
* Download link in README

Fixes twbs#31585

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
meta v5
Projects
No open projects
v5.0.0-alpha2
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link from Readme to download the latest release
3 participants
@ffoodd @XhmikosR @mdo