Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ellipsis Unicode symbol with three dots. #31774

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Conversation

XhmikosR
Copy link
Member

No description provided.

@XhmikosR XhmikosR requested a review from mdo September 28, 2020 09:36
@XhmikosR XhmikosR requested a review from a team as a code owner September 28, 2020 09:36
@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha2 via automation Sep 28, 2020
v5.0.0-alpha2 automation moved this from Inbox to Approved Sep 28, 2020
@XhmikosR XhmikosR merged commit ec812dc into main Sep 28, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Sep 28, 2020
@XhmikosR XhmikosR deleted the main-xmr-rm-hellip branch September 28, 2020 12:01
@martinbean
Copy link
Contributor

What was the reason for this?

@XhmikosR
Copy link
Member Author

Consistency and I personally see no reason to have the UTF-8 character in those places.

@mateusfccp
Copy link

I personally see this as a regression, as the ellipsis unicode char has the exact semantic of that what we are used to.

Ellipses can indicate an unfinished thought, a leading statement, a slight pause, an echoing voice, or a nervous or awkward silence. Aposiopesis is the use of an ellipsis to trail off into silence—for example: "But I thought he was …" When placed at the beginning or end of a sentence, the ellipsis can also inspire a feeling of melancholy or longing.

Three consecutive dots have no defined semantics.

@martinbean
Copy link
Contributor

@mateusfccp Yeah, agreed. It seems bizarre to go from the typographical correct glyph, to the “dumb” equivalent.

@benabraham
Copy link

On console output it‘s understandable.

In documentation it‘s plain wrong.

@ffoodd
Copy link
Member

ffoodd commented Sep 30, 2020

Code example should probably not use the ellipsis character, should they?
While I mostly agree for the typographic concern in the docs, there're plenty of "three dots" and a single ellipsis used appropriately. You may still open a PR for better typography in our odcs, but that's definetely not a priority ATM (while consistency is).

@patrickhlauke
Copy link
Member

purely selfishly...on windows, I find it a pain to type "proper" ellipses. FWIW

@benabraham
Copy link

@ffoodd definitely not the most important problem to spend time on.

Thank you for your work.

@vanillajonathan
Copy link
Contributor

I think … (ellipsis) ought to preferred over ... (three period characters) when appropriate just as – (en dash) and — (em dash) ought to preferred over - (hyphen) when appropriate.

@martinbean
Copy link
Contributor

I don’t know about you chaps, but my files are saved with UTF-8 encoding in my text editor, and my stock terminal uses UTF-8 encoding. So I’m not sure why people are hesitant to use appropriate UTF-8-encoded glyphs for typographic elements?

I guess I’ll be in the minority when I say I use “smart” apostrophes in my code comments as well, now 🙂

@ffoodd
Copy link
Member

ffoodd commented Sep 30, 2020

No one hesitates here:

  1. we have other topics to cover, which are much more valuable for Bootstrap as a product than appropriate typograpy in our docs, obviously;
  2. as Patrick mentions, using appropriate typographic glyphs isn't trivial on Windows.

We're still opened to PR, if one have time for this 🙂

olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5.0.0-alpha2
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

7 participants