Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Vertical pills fix on mobile #31785

Merged
merged 2 commits into from
Sep 29, 2020
Merged

v5: Vertical pills fix on mobile #31785

merged 2 commits into from
Sep 29, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 28, 2020

Change grid classes to utilities to make vertical nav example more resilient to narrow viewports.

/cc @XhmikosR

Fixes #31771

Non-whitespace diff: https://github.com/twbs/bootstrap/pull/31785/files?w=1
Preview: https://deploy-preview-31785--twbs-bootstrap.netlify.app/docs/5.0/components/navs/#javascript-behavior

@XhmikosR
Copy link
Member

@mdo you want this patch in alpha 2?

@mdo
Copy link
Member Author

mdo commented Sep 28, 2020

Your call, @XhmikosR :).

@XhmikosR
Copy link
Member

Let's add it to alpha 2, I'm hoping to rebuild everything anyway :)

@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha2 via automation Sep 28, 2020
@MartijnCuppens MartijnCuppens changed the title Fixes #31771 v5: Vertical pills fix on mobile Sep 28, 2020
v5.0.0-alpha2 automation moved this from Inbox to Approved Sep 29, 2020
@XhmikosR XhmikosR merged commit 1872133 into main Sep 29, 2020
v5.0.0-alpha2 automation moved this from Approved to Shipped Sep 29, 2020
@XhmikosR XhmikosR deleted the js-vertical-tabs-no-grid branch September 29, 2020 07:11
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
…silient to narrow viewports (twbs#31785)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-alpha2
  
Shipped
Development

Successfully merging this pull request may close these issues.

v5 vertical pills regression
2 participants