Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: switch to fenced codeblocks #31806

Merged
merged 1 commit into from Oct 19, 2020
Merged

docs: switch to fenced codeblocks #31806

merged 1 commit into from Oct 19, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 1, 2020

Opening to hear your thoughts, but along with #31802 this might be better since most people should already be familiar with this syntax. As a plus, this works on GitHub too.

@patrickhlauke
Copy link
Member

i'd be in favor of this, assuming the highlighting then still works

@mdo
Copy link
Member

mdo commented Oct 1, 2020

Nice, definitely into it.

@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha3 via automation Oct 4, 2020
@XhmikosR XhmikosR marked this pull request as ready for review October 5, 2020 18:10
@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 5, 2020

This was done with a regex, and there were a few cases with one liners that broke and I had to fix manually, but apart from that everything else should be good to go.

@XhmikosR XhmikosR force-pushed the main-xmr-docs-fenced branch 2 times, most recently from f8b848b to bdbdf8b Compare October 13, 2020 16:11
v5.0.0-alpha3 automation moved this from Inbox to Approved Oct 19, 2020
@XhmikosR XhmikosR merged commit e6618a6 into main Oct 19, 2020
v5.0.0-alpha3 automation moved this from Approved to Shipped Oct 19, 2020
@XhmikosR XhmikosR deleted the main-xmr-docs-fenced branch October 19, 2020 09:56
This was referenced Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-alpha3
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants