Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move href attribute first #31835

Merged
merged 2 commits into from Oct 22, 2020
Merged

Move href attribute first #31835

merged 2 commits into from Oct 22, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 5, 2020 •
edited

Move href attribute first

@mdo not sure what the order should be? If it's supposed to be the other way around let me know and I'll update the branch.

@XhmikosR XhmikosR added the docs label Oct 5, 2020
@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha3 via automation Oct 5, 2020
@XhmikosR XhmikosR requested a review from mdo October 13, 2020 13:51
mdo
mdo reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like including href first so it's clearer earlier in the line what's being imported, if that makes sense. I could go either way though since these aren't regularly updated or anything.

@XhmikosR XhmikosR requested a review from mdo October 14, 2020 03:57
@XhmikosR XhmikosR marked this pull request as ready for review October 14, 2020 03:57
@XhmikosR XhmikosR changed the title Update stylesheet.html Move href attribute first Oct 14, 2020
v5.0.0-alpha3 automation moved this from Inbox to Approved Oct 21, 2020
@XhmikosR XhmikosR merged commit 5a3f273 into main Oct 22, 2020
v5.0.0-alpha3 automation moved this from Approved to Shipped Oct 22, 2020
@XhmikosR XhmikosR deleted the XhmikosR-patch-1 branch October 22, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
docs
Projects
No open projects
v5.0.0-alpha3
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @mdo