Update _syntax.scss #32117
Merged
Update _syntax.scss #32117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All right, I think we can merge this after I sort the selectors so that we have the latest ones. That being said, the differences we see are either bugs or lack of implementation on the chroma side. If someone could report some of the issues upstream, that would help :) |
Jp-watcher
approved these changes
Nov 23, 2020
mdo
approved these changes
Nov 23, 2020
XhmikosR
added a commit
that referenced
this pull request
Nov 24, 2020
* Update _syntax.scss with the latest chroma selectors * Sort selectors * Remove no longer needed chroma workaround * remove comments
XhmikosR
added a commit
that referenced
this pull request
Nov 24, 2020
* Update _syntax.scss with the latest chroma selectors * Sort selectors * Remove no longer needed chroma workaround * remove comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR which adds any missing chroma classes. Unfortunately, it seems it's not as simple as specifying the color for
.nxsince it breaks highlighting in other places like variable declarations.Open for suggestions and we will probably need to report any issues upstream.
PS. if we find a solution, I'll sort the selectors to make things easier in the future to see the diff.
Refs #32104.
/CC @coliff for any suggestions