Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow constructors to accept a CSS selector #32245

Merged
merged 11 commits into from Feb 22, 2021
Merged

Allow constructors to accept a CSS selector #32245

merged 11 commits into from Feb 22, 2021

Conversation

rohit2sharma95
Copy link
Collaborator

@rohit2sharma95 rohit2sharma95 commented Nov 24, 2020 •
edited

@rohit2sharma95 rohit2sharma95 mentioned this pull request Nov 24, 2020
Merged
6 tasks
@rohit2sharma95
Copy link
Collaborator Author

IMO this PR should move after #29370

@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta1 via automation Dec 2, 2020
@XhmikosR XhmikosR removed this from Inbox in v5.0.0-beta1 Dec 2, 2020
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta2 via automation Dec 2, 2020
@rohit2sharma95 rohit2sharma95 force-pushed the selector-in-constructor branch 2 times, most recently from a2b7fa6 to ba5446c Compare December 5, 2020 19:59
@XhmikosR XhmikosR removed this from Inbox in v5.0.0-beta2 Dec 14, 2020
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta3 via automation Dec 14, 2020
@rohit2sharma95 rohit2sharma95 force-pushed the selector-in-constructor branch 2 times, most recently from 0c2920b to bf74944 Compare December 21, 2020 19:04
@rohit2sharma95
Copy link
Collaborator Author

@XhmikosR CSS selectors should be added in the code snippets in the docs?

@rohit2sharma95 rohit2sharma95 marked this pull request as ready for review December 21, 2020 19:07
@rohit2sharma95 rohit2sharma95 requested a review from a team as a code owner December 21, 2020 19:07
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0-beta3 Feb 9, 2021
@mdo
Copy link
Member

mdo commented Feb 19, 2021

@rohit2sharma95 @XhmikosR I see this needs docs—anything I can help with?

v5.0.0-beta3 automation moved this from Review to Approved Feb 22, 2021
@XhmikosR XhmikosR merged commit dc5e332 into twbs:main Feb 22, 2021
v5.0.0-beta3 automation moved this from Approved to Done Feb 22, 2021
@rohit2sharma95 rohit2sharma95 deleted the selector-in-constructor branch February 22, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@XhmikosR XhmikosR Awaiting requested review from XhmikosR

Assignees
No one assigned
Labels
feature js v5
Projects
No open projects
v5.0.0-beta3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow our constructors to accept a CSS selector
3 participants
@rohit2sharma95 @mdo @XhmikosR