Move migration sidebar entry to sidebar.yml #32332
Conversation
XhmikosR
force-pushed
the
main-xmr-docs-mv-migration
branch
from
52efef6
to
2a3580a
Compare
|
Right now this breaks the sidebar text rendering (too bold) and I don't see a Migration link anywhere. |
Too bold? It's bold when it's active only? But yeah, the last patch is WIP. If you revert it, it will work. I'm just not sure what our plan is like I say in my OP:
|
XhmikosR
force-pushed
the
main-xmr-docs-mv-migration
branch
from
4bf07c3
to
d2a5068
Compare
|
I still need some help with the remaining TODO, but assuming we always want the separator to show for each group entry that doesn't have sub pages, this should be better for maintenance. |
ffoodd
force-pushed
the
main-xmr-docs-mv-migration
branch
from
cb730a1
to
98f46cf
Compare
|
@XhmikosR I simplified the active state markup-side, since the active class can be added on the link (as it's done for subnavs) without any side-effect. Also fixed an invalid value CSS-side, flagged by my IDE. |
ffoodd
force-pushed
the
main-xmr-docs-mv-migration
branch
from
1a4b28c
to
a579f54
Compare
XhmikosR
force-pushed
the
main-xmr-docs-mv-migration
branch
from
a579f54
to
26dee68
Compare
| <li{{ if $is_active_group }} class="active"{{ end }}> | ||
| <a href="/docs/{{ $.Site.Params.docs_version }}/{{ $group_slug }}/" class="d-inline-flex align-items-center rounded"> | ||
| <li> | ||
| <a href="/docs/{{ $.Site.Params.docs_version }}/{{ $group_slug }}/" class="d-inline-flex align-items-center rounded{{ if $is_active_group }} active{{ end }}"{{ if $is_active_group }} aria-current="page"{{ end }}> |
| <li{{ if $is_active_group }} class="active"{{ end }}> | ||
| <a href="/docs/{{ $.Site.Params.docs_version }}/{{ $group_slug }}/" class="d-inline-flex align-items-center rounded"> | ||
| <li> | ||
| <a href="/docs/{{ $.Site.Params.docs_version }}/{{ $group_slug }}/" class="d-inline-flex align-items-center rounded{{ if $is_active_group }} active{{ end }}"{{ if $is_active_group }} aria-current="page"{{ end }}> |
TODO:
.bd-links .btn[aria-expanded="true"]doesn't not cover the case, like in the Migration link