Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v5] Checkbox background and transition #32367

Closed
robinheidrich opened this issue Dec 7, 2020 · 1 comment · Fixed by #32793
Closed

[v5] Checkbox background and transition #32367

robinheidrich opened this issue Dec 7, 2020 · 1 comment · Fixed by #32793
Labels
css has-pr v5
Projects
v5.0.0-beta2

Comments

@robinheidrich
Copy link

robinheidrich commented Dec 7, 2020 •
edited

I have two suggestions for the checkbox.

  1. Currently the Sass variable $form-check-input-bg uses $body-bg as default, I think using $input-bg would be better.

  2. Remove the transition for background-color (probably also for border-color) from .form-check-input. The background color should be applied immediately when you release the mouse button to make it look smoother.
@mdo mdo added css v5 and removed feature labels Jan 14, 2021
@mdo mdo mentioned this issue Jan 14, 2021
Merged
@mdo
Copy link
Member

mdo commented Jan 14, 2021

Coming in #32793.

@mdo mdo added the has-pr label Jan 14, 2021
@mdo mdo added this to Inbox in v5.0.0-beta3 via automation Jan 14, 2021
@mdo mdo added this to Inbox in v5.0.0-beta2 via automation Jan 15, 2021
@mdo mdo removed this from Inbox in v5.0.0-beta3 Jan 15, 2021
v5.0.0-beta2 automation moved this from Inbox to Done Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v5
Projects
No open projects
v5.0.0-beta2
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change .form-check background to $input-bg and change transitions twbs/bootstrap
2 participants
@mdo @robinheidrich