Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TRANSITION_END from utils #32394

Merged
merged 4 commits into from Dec 10, 2020
Merged

Remove TRANSITION_END from utils #32394

merged 4 commits into from Dec 10, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Dec 9, 2020 •
edited

This was useful in v4-dev and back when we supported older browsers.

TODO:

  • Drop the variable completely from plugins?

@XhmikosR XhmikosR marked this pull request as ready for review December 9, 2020 21:59
@XhmikosR XhmikosR requested a review from a team as a code owner December 9, 2020 21:59
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta2 via automation Dec 9, 2020
@rohit2sharma95
Copy link
Collaborator

What if you use 'transitionend' instead of TRANSITION_END in utils also? 🤔 Because now it is used everywhere else as a string.

@XhmikosR
Copy link
Member Author

TBH it mostly seems like unnecessary optimization right now. It made sense back when we supported more browsers.

v5.0.0-beta2 automation moved this from Inbox to Approved Dec 10, 2020
@XhmikosR XhmikosR merged commit 1edec54 into main Dec 10, 2020
v5.0.0-beta2 automation moved this from Approved to Done Dec 10, 2020
@XhmikosR XhmikosR deleted the main-xmr-js-rm-trans-end branch December 10, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit2sharma95 rohit2sharma95 rohit2sharma95 approved these changes

Assignees
No one assigned
Labels
js v5
Projects
No open projects
v5.0.0-beta2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @rohit2sharma95