Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL improvements #32436

Merged
merged 4 commits into from Dec 14, 2020
Merged

RTL improvements #32436

merged 4 commits into from Dec 14, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Dec 11, 2020 •
edited

Fixes #32327

@ffoodd ffoodd force-pushed the main-fod-RTL-patches branch 2 times, most recently from a6a2281 to e181325 Compare December 11, 2020 14:21
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta2 via automation Dec 11, 2020
@ffoodd ffoodd marked this pull request as ready for review December 11, 2020 15:19
@ffoodd ffoodd requested review from a team as code owners December 11, 2020 15:19
@ffoodd
Copy link
Member Author

ffoodd commented Dec 11, 2020

FWIW it's only missing the JS tests, but it's tracked in #32330 too. So this PR might be considered as simple patches.

@XhmikosR
Copy link
Member

@FaridAghili can you please check this branch preview please? https://deploy-preview-32436--twbs-bootstrap.netlify.app/docs/5.0/examples/cheatsheet-rtl/

@FaridAghili
Copy link

@XhmikosR @ffoodd
Keyboard direction is fixed and works as expected in RTL.

Same should be done for touch too: here and here

@ffoodd ffoodd mentioned this pull request Dec 11, 2020
Open
20 tasks
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0-beta2 Dec 12, 2020
@ffoodd
Copy link
Member Author

ffoodd commented Dec 14, 2020

Thanks @FaridAghili, fixed ;)

@ffoodd ffoodd mentioned this pull request Dec 14, 2020
Closed
v5.0.0-beta2 automation moved this from Review to Approved Dec 14, 2020
@XhmikosR XhmikosR merged commit b85ca04 into main Dec 14, 2020
v5.0.0-beta2 automation moved this from Approved to Done Dec 14, 2020
@XhmikosR XhmikosR deleted the main-fod-RTL-patches branch December 14, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
css js needs tests rtl v5
Projects
No open projects
v5.0.0-beta2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTL bugs
3 participants
@ffoodd @XhmikosR @FaridAghili