Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant pointer-events: none override for tooltip and popover disabled buttons #32478

Merged
merged 3 commits into from Dec 15, 2020

Conversation

florianlacreuse
Copy link
Contributor

No longer needed since disabled buttons elements now have pointer-events: none applied to. It looks cleaner.

&:disabled,
&.disabled,
fieldset:disabled & {
pointer-events: none;
opacity: $btn-disabled-opacity;
@include box-shadow(none);
}

@patrickhlauke patrickhlauke added this to Inbox in v5.0.0-beta2 via automation Dec 14, 2020
v5.0.0-beta2 automation moved this from Inbox to Approved Dec 15, 2020
@XhmikosR XhmikosR changed the title Remove redundant pointer-events: none; override for tooltip and popover disabled buttons Remove redundant pointer-events: none override for tooltip and popover disabled buttons Dec 15, 2020
@XhmikosR XhmikosR merged commit e8d14b3 into twbs:main Dec 15, 2020
v5.0.0-beta2 automation moved this from Approved to Done Dec 15, 2020
@florianlacreuse florianlacreuse deleted the ft-tooltip-btn-disabled branch December 15, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-beta2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants