modal: move common code to reusable functions #32511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
combine-modal-element-style-modifications
branch
from
e7b4d12
to
1b9d76e
Compare
XhmikosR
changed the title
XhmikosR
reviewed
Dec 18, 2020
GeoSot
force-pushed
the
combine-modal-element-style-modifications
branch
from
925b0a7
to
fa66769
Compare
rohit2sharma95
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine 2 sets of 3 different code blocks in the name of minification.
It doesn't change functionality, only de-duplicates some code