Add an actual data-bs-touch="false" example in the carousel docs
#32638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can also make it easier to actually check/debug any issues we may have with this data attribute
patrickhlauke
force-pushed
the
patrickhlauke-carousel-touch
branch
from
af2a6a2
to
e0fa28f
Compare
|
So it means the issue can not be reproduced in the main branch? (I can see that touch events are not working when |
correct, I edited/added this to the other issue about the supposed bug itself. still would like this as an addition to the docs regardless, as it makes it nice and obvious |
rohit2sharma95
changed the title
data-touch="false" example in the carousel docsdata-bs-touch="false" example in the carousel docs
rohit2sharma95
approved these changes
Dec 28, 2020
patrickhlauke
force-pushed
the
patrickhlauke-carousel-touch
branch
from
26862d1
to
7608c04
Compare
looking at the code, it's still `ride`, not `slide`the `if "carousel"` bit was rather unclear/confusing
patrickhlauke
force-pushed
the
patrickhlauke-carousel-touch
branch
from
8bf3bee
to
8873ec9
Compare
patrickhlauke
force-pushed
the
patrickhlauke-carousel-touch
branch
from
e9c1d48
to
7ed36cc
Compare
XhmikosR
reviewed
Dec 29, 2020
| </tr> | ||
| <tr> | ||
| <td><code>slide</code></td> | ||
| <td><code>ride</code></td> |
There was a problem hiding this comment.
Wonder why this was slide all this time...
There was a problem hiding this comment.
yes, either I missed something, or we've had a typo in the options all along...
(admittedly it's the first time I've properly looked at our carousels, but still)
There was a problem hiding this comment.
Yeah, it looks like it's a typo AFAICT. Going to merge this later.
sijusamson
pushed a commit
to sijusamson/bootstrap
that referenced
this pull request
Jan 4, 2021
…wbs#32638) * Add an actual `data-touch="false"` example in the carousel docs this can also make it easier to actually check/debug any issues we may have with this data attribute * Correct attribute table explanation and remove slide class from example
patrickhlauke
added a commit
that referenced
this pull request
Jan 5, 2021
…32639) * v4: Add an actual `data-touch="false"` example in the carousel docs Backport of #32638 * Remove data-ride from example carousel * Correct attribute table explanation and remove slide class from example i believe the correct option is `slide` here, not `ride`. the `if "carousel"` bit was rather unclear/confusing * Edits... sorry, trying to make sense of our quirky carousel stuff, it seems some illogical things have been there ever since * Add data-interval to suppress autoplay * Tweak carousel options formatting * Update site/content/docs/4.5/components/carousel.md Co-authored-by: Mark Otto <markd.otto@gmail.com> * Tweak language mostly based on @mdo's suggestion, but also adds the word "attribute" after `data-ride` for better flow/legibility Co-authored-by: Mark Otto <markd.otto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can also make it easier to actually check/debug any issues we may have with this data attribute