Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carousel example: Move "active" class on .nav-link element #32647

Merged
merged 2 commits into from Jan 5, 2021

Conversation

chtitux
Copy link
Contributor

@chtitux chtitux commented Dec 29, 2020

The "active" CSS class must be on "nav-link" element, see _navbar.scss:

    .nav-link.active {
      color: $navbar-dark-active-color;
    }

With fix

image

Without fix

image

The "active" CSS class must be on "nav-link" element, see `_navbar.scss`:

```css
    .nav-link.active {
      color: $navbar-dark-active-color;
    }
```
@XhmikosR XhmikosR requested a review from ffoodd December 29, 2020 13:41
@mdo mdo added this to Inbox in v5.0.0-beta2 via automation Jan 5, 2021
v5.0.0-beta2 automation moved this from Inbox to Approved Jan 5, 2021
@XhmikosR XhmikosR merged commit 265605b into twbs:main Jan 5, 2021
v5.0.0-beta2 automation moved this from Approved to Done Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-beta2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants