Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong fallback placement for dropdown #32648

Closed
rohit2sharma95 opened this issue Dec 29, 2020 · 0 comments · Fixed by #32843
Closed

Wrong fallback placement for dropdown #32648

rohit2sharma95 opened this issue Dec 29, 2020 · 0 comments · Fixed by #32843
Labels

Comments

@rohit2sharma95
Copy link
Collaborator

When positioned with Popper, fallback placement for dropdown seems wrong.

Current behavior
(Flipped with top placement)
Expected behavior
(Flipped with top-end placement)
wrong-fallback right-fallback

Because the changes made in #32405 override the Popper's default value for fallbackPlacement that is [oppositePlacement]. By default Popper places the element to the opposite side (like bottom-end => top-end and bottom => top).

Now Popper can place the element to the specified positions only:

{
name: 'flip',
options: {
fallbackPlacements: ['top', 'right', 'bottom', 'left']
}
}]

But these changes are good for Tooltip/Popover (Because they are not placed to the edges of the reference element)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant