Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registering components in V5 as jQuery plugins prevents treeshaking #32664

Open
Bobris opened this issue Jan 3, 2021 · 1 comment
Open

Registering components in V5 as jQuery plugins prevents treeshaking #32664

Bobris opened this issue Jan 3, 2021 · 1 comment
Labels
feature help wanted

Comments

@Bobris
Copy link

Bobris commented Jan 3, 2021 •
edited

It is nice that V5 removes dependency on jQuery, but every component still try to register as jQuery pluging if jQuery is available. But that makes all components as used in every treeshaking or dead code elimination bundler.

It would be good to have bootstrap build version without this code making applicactions much smaller if they will use only some components.
@Bobris Bobris added the feature label Jan 3, 2021
@XhmikosR
Copy link
Member

XhmikosR commented Jan 5, 2021

PRs welcome.

@xrkffgg xrkffgg mentioned this issue Jan 7, 2021
Closed
@rohit2sharma95 rohit2sharma95 mentioned this issue Jun 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bobris @XhmikosR