Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs regarding RTL migration #32771

Merged
merged 4 commits into from Jan 13, 2021
Merged

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Jan 12, 2021

Tackles a few things from #32330

@ffoodd ffoodd force-pushed the main-fod-docs-remaining-rtl branch from b61a6ba to 2a9d32d Compare January 12, 2021 15:53
@ffoodd ffoodd mentioned this pull request Jan 12, 2021
20 tasks
@ffoodd ffoodd marked this pull request as ready for review January 12, 2021 16:31
@ffoodd ffoodd force-pushed the main-fod-docs-remaining-rtl branch from b2ebbee to 590cf7c Compare January 12, 2021 16:35
@ffoodd ffoodd requested review from XhmikosR and mdo January 12, 2021 16:40
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@mdo mdo added this to Inbox in v5.0.0-beta2 via automation Jan 13, 2021
/*rtl:end:options*/
```

After running Sass then RTLCSS, each selector in your CSS files will be prepended by `.ltr`, and `.rtl` for RTL files. Now you're able to use both files on the same page, and simply use `.ltr` or `rtl` on your components wrappers to use one or the other direction.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a dot in rtl class name.

@XhmikosR XhmikosR merged commit 20a9d49 into main Jan 13, 2021
v5.0.0-beta2 automation moved this from Inbox to Done Jan 13, 2021
@XhmikosR XhmikosR deleted the main-fod-docs-remaining-rtl branch January 13, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-beta2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants