Fix default value for $enable-deprecation-messages
#32940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen in the https://github.com/twbs/bootstrap/blob/main/scss/_variables.scss, the $enable-deprecation-messages variable (line 220) is set to `true` by default. Direct permalink to the line 220 @ GitHub: https://github.com/twbs/bootstrap/blob/e79c8f3489527d7f5eef2bb3cf14856f26c49871/scss/_variables.scss#L220
|
Weird, it seems we have the same in v4-dev @mdo. |
XhmikosR
changed the title
$enable-deprecation-messages
ffoodd
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
@XhmikosR You're right, the same in v4.6.
Left another comment regarding version: v5 should mention deprecation for v6, shouldn't it?
ffoodd
requested changes
Feb 3, 2021
Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
XhmikosR
moved this from Needs manual backport
to Cherry-picked/Manually backported
in v4.6.1
XhmikosR
added a commit
that referenced
this pull request
Feb 15, 2021
* Update the default value for $enable-deprecation-messages As seen in the https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss, the `$enable-deprecation-messages` variable is set to `true` by default.
XhmikosR
added a commit
that referenced
this pull request
Feb 17, 2021
* Update the default value for $enable-deprecation-messages As seen in the https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss, the `$enable-deprecation-messages` variable is set to `true` by default.
XhmikosR
added a commit
that referenced
this pull request
Feb 17, 2021
* Update the default value for $enable-deprecation-messages As seen in the https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss, the `$enable-deprecation-messages` variable is set to `true` by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in the https://github.com/twbs/bootstrap/blob/main/scss/_variables.scss, the
$enable-deprecation-messagesvariable (line 220) is set totrueby default.Direct permalink to the line 220 @ GitHub:
bootstrap/scss/_variables.scss
Line 220 in e79c8f3