Add ol.list-group with pseudo-element numbers
#33068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to add this in the next beta IMO, so slating for either v5-stable or v5.1. |
XhmikosR
changed the title
ol.list-group with pseudo-element numbers
ffoodd
approved these changes
Feb 15, 2021
|
I would think this is better suited for an additional class. I for one often use |
|
Updated to use a class so that it's opt-in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26202, closes #32244.
Originally mentioned by me at #32244 (comment).
Uses generated content via CSS to add the numbers inside list group items. This is done because the styling available for normal ordered/numbered lists affords basically no ability to style, place, align, etc the numbers. This way, people can apply their own custom styles to the
::beforeelement and match or differentiate them as desired.Preview: https://deploy-preview-33068--twbs-bootstrap.netlify.app/docs/5.0/components/list-group/#ordered-list