Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validated controls border in input-group #33211

Merged
merged 1 commit into from Mar 1, 2021
Merged

Validated controls border in input-group #33211

merged 1 commit into from Mar 1, 2021

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Feb 26, 2021 •
edited

@ffoodd ffoodd requested a review from a team as a code owner February 26, 2021 09:10
mdo
mdo approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on isolating this to the validation styles, and on the change here.

@mdo mdo added this to Inbox in v5.0.0-beta3 via automation Feb 27, 2021
@mdo mdo merged commit ac3a106 into main Mar 1, 2021
v5.0.0-beta3 automation moved this from Inbox to Done Mar 1, 2021
@mdo mdo deleted the main-fod-input-group-validation branch March 1, 2021 15:53
@korki43 korki43 mentioned this pull request Apr 3, 2021
Closed
@jatinmehta jatinmehta mentioned this pull request Apr 15, 2021
Merged
@florianlacreuse florianlacreuse mentioned this pull request Aug 30, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@tkrotoff tkrotoff tkrotoff approved these changes

@CyberFlameGO CyberFlameGO CyberFlameGO approved these changes

Assignees
No one assigned
Labels
backport-to-v4 css v5
Projects
No open projects
v5.0.0-beta3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

input-group validation wrong right border color
4 participants
@ffoodd @mdo @tkrotoff @CyberFlameGO