Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example: toggle modal dialogs #33301

Merged
merged 12 commits into from Mar 17, 2021
Merged

Add example: toggle modal dialogs #33301

merged 12 commits into from Mar 17, 2021

Conversation

WinterSilence
Copy link
Contributor

No description provided.

@XhmikosR
Copy link
Member

XhmikosR commented Mar 8, 2021

Not sure what this is supposed to show?

@WinterSilence
Copy link
Contributor Author

@XhmikosR https://codepen.io/WinterSilence/pen/NWbLZWW

@XhmikosR
Copy link
Member

XhmikosR commented Mar 8, 2021

The example does not render right. Also use triple backticks and two-space indentation.

Regardless, I'm not sure if this should land.

@WinterSilence
Copy link
Contributor Author

The example does not render right.

what's problem?

I'm not sure if this should land.

what's you mean?

@XhmikosR
Copy link
Member

XhmikosR commented Mar 8, 2021

Please check the other examples: https://deploy-preview-33301--twbs-bootstrap.netlify.app/docs/5.0/components/modal/#toggle-dialogs

what's you mean?

I mean, I'm not sure it gives any value the way it currently is.

@XhmikosR XhmikosR marked this pull request as draft March 8, 2021 17:02
@WinterSilence
Copy link
Contributor Author

@XhmikosR for example: "Login" dialog can contain button/link to open "Reset password" dialog

@WinterSilence
Copy link
Contributor Author

@XhmikosR

Please check the other examples

they are not similar - cant find common pattern, if need fix some moments just say "fix ..."

@WinterSilence WinterSilence marked this pull request as ready for review March 8, 2021 19:26
@devhoussam
Copy link
Contributor

@XhmikosR for example: "Login" dialog can contain button/link to open "Reset password" dialog

this is a great solution 👍 💯

@WinterSilence WinterSilence requested a review from mdo March 11, 2021 02:28
@mdo mdo added this to Inbox in v5.0.0-beta3 via automation Mar 12, 2021
@WinterSilence
Copy link
Contributor Author

@mdo thanks for help!

v5.0.0-beta3 automation moved this from Inbox to Approved Mar 17, 2021
@mdo mdo merged commit fcac2e3 into twbs:main Mar 17, 2021
v5.0.0-beta3 automation moved this from Approved to Done Mar 17, 2021
@WinterSilence WinterSilence deleted the patch-2 branch March 17, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@XhmikosR XhmikosR Awaiting requested review from XhmikosR

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.0.0-beta3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WinterSilence @XhmikosR @devhoussam @mdo