Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update look and feel of examples and copy buttons #33404

Merged
merged 1 commit into from Apr 5, 2021
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Mar 19, 2021

Screen Shot 2021-03-18 at 10 08 16 PM

Restores some of the look and feel from previous versions :). More specifically:

  • Adds border around the code snippets
  • Removes the blue coloring around Copy buttons
  • Adds the language at the top of each code snippet
  • Includes some messy code for attaching multiple code snippets to an example (see above screenshot)—would love help cleaning this up somehow. Maybe I just wrap it all in some custom HTML? Something else?

/cc @XhmikosR

@mdo mdo marked this pull request as ready for review March 19, 2021 17:50
@mdo mdo requested a review from a team as a code owner March 19, 2021 17:50
@mdo mdo added this to Inbox in v5.0.0 via automation Mar 23, 2021
@mdo
Copy link
Member Author

mdo commented Apr 5, 2021

Going to ship this as-is and iterate in other PRs as we go :).

@mdo mdo merged commit cdf56e0 into main Apr 5, 2021
v5.0.0 automation moved this from Inbox to Done Apr 5, 2021
@mdo mdo deleted the redesign-examples branch April 5, 2021 03:21
@XhmikosR
Copy link
Member

XhmikosR commented Apr 5, 2021

@mdo we need to get this fixed :)

image

.chroma {
.language-bash,
.language-sh {
&::before {
color: #009;
content: "$ ";
user-select: none;
}
}
.language-powershell::before {
color: #009;
content: "PM> ";
user-select: none;
}
}

@mdo mdo removed this from Done in v5.0.0 Apr 7, 2021
@XhmikosR XhmikosR added the skip-changelog So that the release drafter action doesn't include it label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs skip-changelog So that the release drafter action doesn't include it v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants