Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab content of active tab (inside a Accordion) disappears after opening the Accordion. #34698

Closed
sebastianbrosch opened this issue Aug 5, 2021 · 7 comments · Fixed by #34835
Assignees
Labels
Projects

Comments

@sebastianbrosch
Copy link

sebastianbrosch commented Aug 5, 2021

Operating system: Windows 10
Browser: Google Chrome 92.0.4515.131

Since Bootstrap 5.1.0 the tab content of the first tab inside a Accordion isn't visible anymore.

Demo Bootstrap 5.0.2 (working): https://codepen.io/sebastianbrosch/pen/NWjONrJ
Demo Bootstrap 5.1.0 (not working): https://codepen.io/sebastianbrosch/pen/LYyBXpa

After reopening the Accordion the content of the first Tab disappears. Opening the Accordion is removing .show class from .tab-pane (and also adds a .collapse class to .tab-pane). The content of the active tab disappears after reopening the Accordion.

It looks like this commit caused the issue: bb66855. If I revert this commit and try the example above the tabs are working again.

@dariocarbone
Copy link

Same issue here....it seems related to nested tab panels inside accordions

@GeoSot GeoSot self-assigned this Aug 27, 2021
@dariocarbone
Copy link

any workaround doable at this time?

@GeoSot
Copy link
Member

GeoSot commented Aug 28, 2021

@sebastianbrosch thank you for your examples,

I have made a regression MR #34835 .
Please use the following script and confirm that it works fine
https://deploy-preview-34835--twbs-bootstrap.netlify.app/docs/5.1/dist/js/bootstrap.bundle.min.js

@dariocarbone
Copy link

Now it works flawless, hoping it will be a new official release soon, thanks. Sorry for bothering you, but could you please link even a bootstrap.esm.min script?

@sebastianbrosch
Copy link
Author

@dariocarbone https://deploy-preview-34835--twbs-bootstrap.netlify.app/docs/5.1/dist/js/bootstrap.esm.min.js

@sebastianbrosch
Copy link
Author

@GeoSot It is working fine using the deploy preview: https://codepen.io/sebastianbrosch/pen/OJgVRbP

@GeoSot
Copy link
Member

GeoSot commented Aug 29, 2021

Really, thank you both guys

@XhmikosR XhmikosR added this to Done in v5.1.1 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.1.1
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants