Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap-reboot.css variables not defined in 5.1 #34710

Closed
jaryn-kubik opened this issue Aug 8, 2021 · 2 comments · Fixed by #34773
Closed

bootstrap-reboot.css variables not defined in 5.1 #34710

jaryn-kubik opened this issue Aug 8, 2021 · 2 comments · Fixed by #34773

Comments

@jaryn-kubik
Copy link

Looking at https://github.com/twbs/bootstrap/blob/fd92e353d078175074af35a94b7a237c64d6767a/dist/css/bootstrap-reboot.css for example body.font-family is defined using css variable var(--bs-body-font-family).

But these variables are not defined anywhere. Shouldn't bootstrap-reboot.scss also import _root.scss that defines these?
Maybe I'm missing something but including just bootstrap-reboot.css no longer works on it's own and it did before.

@ffoodd
Copy link
Member

ffoodd commented Aug 8, 2021

That's right, indeed. Using _reboot solely needs to import _root on its own.

FWIW we kind of already knew this, as it's been mentioned in #34577—simply missed the point.

@xiejay97
Copy link

@ffoodd I think provide a default value for css variables would be better.
As font-family: var(--#{$variable-prefix}body-font-family);, if we provide a default value just like this: font-family: var(--#{$variable-prefix}body-font-family, $font-family-base);, we wont need the --#{$variable-prefix}body-font-family variable, it means we can set css variables only when we need.

@XhmikosR XhmikosR added this to In progress in v5.1.1 Aug 23, 2021
v5.1.1 automation moved this from In progress to Done Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.1.1
  
Done
3 participants