Carousel cleanup & refactoring #34945
Merged
+43
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
gs-carousel-cleanup
branch
from
91b1c45
to
63b4db1
Compare
GeoSot
force-pushed
the
gs-carousel-cleanup
branch
2 times, most recently
from
2351b7e
to
29987c7
Compare
GeoSot
force-pushed
the
gs-carousel-cleanup
branch
from
29987c7
to
816301b
Compare
GeoSot
force-pushed
the
gs-carousel-cleanup
branch
from
816301b
to
527dbee
Compare
GeoSot
force-pushed
the
gs-carousel-cleanup
branch
2 times, most recently
from
43c7394
to
b5e5f9b
Compare
XhmikosR
force-pushed
the
gs-carousel-cleanup
branch
3 times, most recently
from
4617407
to
c733a6a
Compare
XhmikosR
previously approved these changes
Dec 10, 2021
XhmikosR
force-pushed
the
gs-carousel-cleanup
branch
from
1aa041b
to
7f1f610
Compare
GeoSot
force-pushed
the
gs-carousel-cleanup
branch
2 times, most recently
from
6eacda6
to
e744d04
Compare
We can achieve the same thing by querying the specific selector directly
XhmikosR
force-pushed
the
gs-carousel-cleanup
branch
3 times, most recently
from
1c90b60
to
3b2a7c7
Compare
According to https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState `visibilityState` is always a string, so the check was always true
XhmikosR
force-pushed
the
gs-carousel-cleanup
branch
from
3b2a7c7
to
8c5a23d
Compare
XhmikosR
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.