Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with style.removeProperty at ScrollbarHelper #35349

Closed
olamedia opened this issue Nov 12, 2021 · 4 comments · Fixed by #35388
Closed

Issue with style.removeProperty at ScrollbarHelper #35349

olamedia opened this issue Nov 12, 2021 · 4 comments · Fixed by #35388
Assignees
Projects

Comments

@olamedia
Copy link

element.style.removeProperty(styleProp)

style.removeProperty ignores paddingRight, should be padding-right
Array access to style uses camelCase, while methods accepts kebab-case
see https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleDeclaration/removeProperty#parameters

property is a DOMString representing the property name to be removed. Note that multi-word property names are hyphenated and not camel-cased.

@XhmikosR XhmikosR added this to To do in v5.2.0 via automation Nov 15, 2021
@GeoSot
Copy link
Member

GeoSot commented Nov 16, 2021

@olamedia please provide at least a live demo of the issue, with description to the problem. Per our contributing guidelines, please create a reduced test case via CodePen or JS Bin

@olamedia
Copy link
Author

https://codepen.io/olamedia/pen/bGrOgZZ

@XhmikosR
Copy link
Member

My main concern here is that both seem to work in #35388. If I copy the test from that PR to main and run it, it passes, but it shouldn't. So, either our test is wrong, or something else is going on.

Any help is welcome!

@olamedia
Copy link
Author

olamedia commented Dec 3, 2021

may be the differences of virtual dom

v5.2.0 automation moved this from To do to Done Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants