Convert border utilities to CSS variables #35428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
force-pushed
the
css-vars-borders
branch
from
619b36f
to
6413893
Compare
alecpl
reviewed
Nov 30, 2021
|
This |
|
Yup, that's coming next :). |
ffoodd
requested changes
Dec 14, 2021
2 tasks
mdo
force-pushed
the
css-vars-borders
branch
3 times, most recently
from
24bc11b
to
9b7f930
Compare
|
Changes addressed @ffoodd, ready for another review :D. |
mdo
force-pushed
the
css-vars-borders
branch
2 times, most recently
from
03df7d8
to
9ecdfcf
Compare
|
Added another commit to replace instances of |
ffoodd
approved these changes
Feb 28, 2022
- Updates the utilities mixin to check for specific CSS variable names via `css-variable` - Bonus fix: we now prevent local variables for `0` value utilities (e.g., `.border-top-0` no longer sets `--bs-border-opacity: 1` - Adds new `.border-opacity-*` classes - Adds new root variables: `--bs-border-color`, `--bs-border-style`, `--bs-border-width` - Documents the new variable changes
…lor and border-width
mdo
force-pushed
the
css-vars-borders
branch
from
9ecdfcf
to
7b2d7f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
css-variable0value utilities (e.g.,.border-top-0no longer sets--bs-border-opacity: 1.border-opacity-*classes--bs-border-color,--bs-border-style,--bs-border-widthTodo: