Rely on border-width for <hr> size
#35491
Merged
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
changed the title
<hr> size
XhmikosR
changed the title
<hr> sizeborder-width for <hr> size
|
So while this makes sense to me, it is a breaking change. |
|
AFAIC We're pretty fine here, but we already have two issues around Does this sound better? |
mdo
reviewed
Feb 10, 2022
Co-authored-by: Mark Otto <markd.otto@gmail.com>
mdo
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34292, fixes #34374, fixes #35616.
A few tries confirmed me that relying on
border-widthas in v4 doesn't imply any side effect, even when using the (deprecated)sizeattribute.I don't see any reason to stick with
heightthen, so ditching this to make our newhrcloser to v4.Contrary to what we said in #34574, we can keep the opacity feature this way. With my current proposal, customizing
hrcould be done using.text-*for color and.border-*for sizing. I'd stick tocurrentColorfor color since it allows inheritance: relying onborder-colorwould require us to define a value (as it was done in v4) but I think it's more valuable to inherit from text color, isn't it?NB: the current migration guide mentions v5.2.0, which is not accurate, is it? Do we maintain a minor versions' migration guide anywhere?