Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visual tests #35585

Merged
merged 3 commits into from Jan 30, 2022
Merged

Fix visual tests #35585

merged 3 commits into from Jan 30, 2022

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Dec 21, 2021 •
edited

They broke in #34509

@XhmikosR XhmikosR added this to In progress in v5.2.0 via automation Dec 21, 2021
@XhmikosR XhmikosR changed the title Main xmr js visual tests Fix visual tests Dec 21, 2021
@XhmikosR
Copy link
Member Author

Perhaps we should just load our bundle in the visual tests too and be done with it?

@GeoSot
Copy link
Member

GeoSot commented Dec 24, 2021 •
edited

Perhaps we should just load our bundle in the visual tests too and be done with it?

I think it is a good idea

@GeoSot GeoSot self-requested a review January 11, 2022 23:18
v5.2.0 automation moved this from In progress to Reviewer approved Jan 11, 2022
@GeoSot GeoSot marked this pull request as ready for review January 11, 2022 23:18
@XhmikosR XhmikosR merged commit 89f8876 into main Jan 30, 2022
v5.2.0 automation moved this from Reviewer approved to Done Jan 30, 2022
@XhmikosR XhmikosR deleted the main-xmr-js-visual-tests branch January 30, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoSot GeoSot GeoSot approved these changes

Assignees
No one assigned
Labels
affects-main-branch tests v5
Projects
No open projects
v5.2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @GeoSot