Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toast close button position #35635

Open
3 tasks done
ZhangChengLin opened this issue Jan 2, 2022 · 7 comments
Open
3 tasks done

toast close button position #35635

ZhangChengLin opened this issue Jan 2, 2022 · 7 comments

Comments

@ZhangChengLin
Copy link
Contributor

Prerequisites

Describe the issue

https://getbootstrap.com/docs/5.1/components/toasts/#basic

The right layout should be added to the close button in the .toast-header.
And the close button in toast modal offcanvas alert does not unify the margin position.

.toast-header .btn-close {
    margin-right: -0.375rem;
    margin-left: 0.75rem;
}


.modal-header .btn-close {
    padding: 0.5rem 0.5rem;
    margin: -0.5rem -0.5rem -0.5rem auto;
}

.offcanvas-header .btn-close {
    padding: 0.5rem 0.5rem;
    margin-top: -0.5rem;
    margin-right: -0.5rem;
    margin-bottom: -0.5rem;
}

.alert-dismissible .btn-close {
    position: absolute;
    top: 0;
    right: 0;
    z-index: 2;
    padding: 1.25rem 1rem;
}

Reduced test cases

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

5.1.3

@ffoodd
Copy link
Member

ffoodd commented Jan 5, 2022

What issue do you have? Close buttons seem to work fine—with various positions depending on the component but that's intended (and customizable through Sass).

@ZhangChengLin
Copy link
Contributor Author

What issue do you have? Close buttons seem to work fine—with various positions depending on the component but that's intended (and customizable through Sass).

When there is only a closing button in Header, the button is closed, not on the right.

@ffoodd
Copy link
Member

ffoodd commented Jan 6, 2022

Would you mind providing a reduced test case on CodePen or something, please?

@ZhangChengLin
Copy link
Contributor Author

Would you mind providing a reduced test case on CodePen or something, please?

https://codepen.io/zhangchenglin/pen/YzrvmMR?editors=1000

1 ×
2 √

Currently, there is no right positioning of the close button in the title like other components.
Other components that contain the close button, such as modal and offcanvas, position the close button to the right.

@mdo
Copy link
Member

mdo commented Feb 10, 2022

Agreed this is inconsistent. The demo markup in our docs breaks though with adding margin-left: auto a la close buttons elsewhere. I'll need to work out a fix there, too. Open to suggestions.

@mdo mdo added the v6 label Dec 29, 2022
@DigitalSolo
Copy link

Still an issue.

@davidsilva
Copy link

Would it work to give <Toast.Header> justify-content: space-between? It works in my case, where I have a string, e.g., "Success," I want flush left and want the close "X" flush right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants