Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New snippet examples #36309

Merged
merged 4 commits into from Feb 15, 2023
Merged

New snippet examples #36309

merged 4 commits into from Feb 15, 2023

Conversation

mdo
Copy link
Member

@mdo mdo commented May 9, 2022

Exploring some new snippets for:

@mdo mdo added this to In progress in v5.3.0 via automation May 9, 2022
@mdo mdo marked this pull request as ready for review January 11, 2023 00:39
@mdo mdo requested a review from a team as a code owner January 11, 2023 00:39
@julien-deramond
Copy link
Member

julien-deramond commented Jan 11, 2023

Just a question with the 2 last examples in the badges. I began the creation of a chip component as a draft but are we saying with these examples that finally a badge and a chip are the same thing? I don't have a strong opinion on it but if we end up creating chips, the border between what's a chip/what's a badge would be very thin 😄

FYI at Orange, we have a separate component because the design/rendering/usage is very different. And TBH, our first version of what we call Tags (so Chips) was using @extend .badge in CSS.

@mdo
Copy link
Member Author

mdo commented Feb 14, 2023

Just a question with the 2 last examples in the badges. I began the creation of a chip component as a draft but are we saying with these examples that finally a badge and a chip are the same thing? I don't have a strong opinion on it but if we end up creating chips, the border between what's a chip/what's a badge would be very thin 😄

FYI at Orange, we have a separate component because the design/rendering/usage is very different. And TBH, our first version of what we call Tags (so Chips) was using @extend .badge in CSS.

Yeah, it's going to be a little messy with stuff like this. These snippets don't or shouldn't represent any kind of official component thinking though. This is just showing how you can take Bootstrap's defaults and do some fun and interesting things, and to help folks move a little faster.

@mdo mdo merged commit 2dc329d into main Feb 15, 2023
@mdo mdo deleted the more-snippets-examples branch February 15, 2023 04:58
@XhmikosR XhmikosR changed the title WIP: New snippet examples New snippet examples Mar 15, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.3.0
In progress
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants