Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home imports #37318

Merged
merged 6 commits into from Oct 22, 2022
Merged

Home imports #37318

merged 6 commits into from Oct 22, 2022

Conversation

mdo
Copy link
Member

@mdo mdo commented Oct 13, 2022

This PR breaks up the homepage's masthead-followup.html partial into more manageable pieces. Made some copy changes alongside it. Fair warning, this might need another pass from me yet—I did this a couple weeks ago and forgot to push the branch until now.

@mdo mdo requested a review from a team as a code owner October 13, 2022 19:13
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments for this PR but the overall is good. Like the new architecture and the small improvements that make the difference.

site/layouts/partials/home/plugins.html Outdated Show resolved Hide resolved
site/layouts/partials/home/plugins.html Outdated Show resolved Hide resolved
site/layouts/partials/home/icons.html Outdated Show resolved Hide resolved
@mdo
Copy link
Member Author

mdo commented Oct 14, 2022

Great feedback all around! Just pushed up some changes to address everything here.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last 2 comments regarding this PR and I think we're good to go 🚀

@Chrisse86

This comment was marked as off-topic.

@mdo mdo merged commit 538f50b into main Oct 22, 2022
@mdo mdo deleted the home-imports branch October 22, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants