Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: New var proposal + init headings-color #37904

Merged
merged 4 commits into from Apr 21, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 17, 2023

Description

Create a new --bs-link-opacity variable.
Change $headings-color from null to inherit.

Motivation & Context

I can't see any breaking change inside those changes but let me know if you spot one !

Harmonize the use of CSS var and fix a weird case in colored links.
Remove a weird behavior of --bs-heading-color which was the only one where we check the initialization. IMO, it could be implemented in Bootstrap but on all the CSS variables.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@mdo mdo merged commit 0bea3f3 into twbs:main Apr 21, 2023
14 of 15 checks passed
@louismaximepiton louismaximepiton deleted the main-lmp-css-var-init branch April 21, 2023 07:42
@XhmikosR
Copy link
Member

FYI the CI checks fail for a reason 😛

Please don't merge blindly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants