Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media-query color mode Sass test #38326

Merged
merged 3 commits into from Mar 26, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 25, 2023

Description

Related to #38322, this PR suggests adding an automatic test to build Bootstrap with $color-mode: "media-query" enabled since we released a version with errors for this use case.

IDK if a kind of "assert true" is mandatory here.

/cc @mdo and @romaricpascal for thoughts

Motivation & Context

Not releasing again a version with errors with $color-mode: "media-query".

Type of changes

  • Enhancement (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

#38322

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've opened a PR to address the selector itself here at #38328.

@julien-deramond
Copy link
Member Author

julien-deramond commented Mar 26, 2023

Rebasing it after #38328.
Should be green now 🙏
If so :shipit:

@julien-deramond julien-deramond marked this pull request as ready for review March 26, 2023 07:55
@julien-deramond julien-deramond requested a review from a team as a code owner March 26, 2023 07:55
@julien-deramond julien-deramond merged commit cd89088 into main Mar 26, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-add-media-query-color-mode-test branch March 26, 2023 07:58
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants