Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: js-docs unindent automatically the code inside shortcode #38349

Merged
merged 1 commit into from Mar 28, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 28, 2023

Description

Based on the magical Hugo stuff done by @louismaximepiton from f8a56da, this PR suggests using the same spell for the new js-docs shortcode in order to have the correct indentation.

Before: (e.g. https://twbs-bootstrap.netlify.app/docs/5.3/components/alerts/#live-example)

Screenshot 2023-03-28 at 11 06 06

Now: (e.g. https://deploy-preview-38349--twbs-bootstrap.netlify.app//docs/5.3/components/alerts/#live-example)

Screenshot 2023-03-28 at 11 06 36

Type of changes

  • Enhancement (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review March 28, 2023 09:08
@XhmikosR XhmikosR merged commit 34c2725 into main Mar 28, 2023
13 of 14 checks passed
@XhmikosR XhmikosR deleted the main-jd-docs-unindent-js-docs-auto branch March 28, 2023 14:01
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants