Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: drop loop #38368

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Modal: drop loop #38368

merged 1 commit into from
Mar 29, 2023

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 29, 2023 •
edited

We only have two elements to iterate over so it doesn't make a lot of sense to use a loop here

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR
Modal: drop loop
f0f52c4 
We only have two elements to iterate over so it doesn't make a lot of sense to use a loop here
@XhmikosR XhmikosR added the js label Mar 29, 2023
@XhmikosR XhmikosR marked this pull request as ready for review March 29, 2023 07:54
@XhmikosR XhmikosR requested a review from a team as a code owner March 29, 2023 07:54
@XhmikosR XhmikosR merged commit 7a7fc1a into main Mar 29, 2023
@XhmikosR XhmikosR deleted the xmr/js-modal-drop-loop branch March 29, 2023 08:00
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoSot GeoSot GeoSot approved these changes

Assignees
No one assigned
Labels
js
Projects
No open projects
v5.3.0-alpha3
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @GeoSot