Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL sanitizer to allow more protocols #38531

Merged
merged 5 commits into from Apr 30, 2023

Conversation

kyletsang
Copy link
Contributor

@kyletsang kyletsang commented Apr 28, 2023

Description

Updates the sanitizer regex to allow more protocols like sip. This takes the updated regex from the same angular sanitizer as the original.

Motivation & Context

Some valid protocols such as sip doesn't work.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #38519

@kyletsang kyletsang requested a review from a team as a code owner April 28, 2023 21:39
js/src/util/sanitizer.js Outdated Show resolved Hide resolved
js/src/util/sanitizer.js Outdated Show resolved Hide resolved
@XhmikosR XhmikosR merged commit d5dee31 into twbs:main Apr 30, 2023
15 checks passed
@kyletsang kyletsang deleted the url-sanitizier branch May 1, 2023 04:53
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanitizer doesn't allow sip in href. Sip links are used for messaging like in Microsoft Teams.
4 participants